doc: docstrings for List.mapM and friends #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
digama0
reviewed
Apr 10, 2024
digama0
approved these changes
Apr 10, 2024
Co-authored-by: Mario Carneiro <[email protected]>
src/Init/Data/List/Control.lean
Outdated
| @@ -71,15 +103,27 @@ def filterAuxM {m : Type → Type v} [Monad m] {α : Type} (f : α → m Bool) : | |||
| let b ← f h | |||
| filterAuxM f t (cond b (h :: acc) acc) | |||
|
|
|||
| /-- | |||
| Applies the monadic predicate `f` on every element in the list, left-to-right, and returns those | |||
There was a problem hiding this comment.
Should we rename f to p?
src/Init/Data/List/Control.lean
Outdated
| @[inline] | ||
| def filterM {m : Type → Type v} [Monad m] {α : Type} (f : α → m Bool) (as : List α) : m (List α) := do | ||
| let as ← filterAuxM f as [] | ||
| pure as.reverse | ||
|
|
||
| /-- | ||
| Applies the monadic predicate `f` on every element in the list, right-to-left, and returns those |
nomeata
commented
Apr 11, 2024
nomeata
commented
Apr 11, 2024
Co-authored-by: David Thrane Christiansen <[email protected]>
david-christiansen
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.